[virt-tools-list] [virt-manager 2/3] virt-manager: add support for adding panic device

[Cole Robinson]

On 01/06/2014 03:04 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  ui/addhardware.ui          | 76 ++++++++++++++++++++++++++++++++++++++++++++--
>  virtManager/addhardware.py | 42 ++++++++++++++++++++++++-
>  2 files changed, 115 insertions(+), 3 deletions(-)
> 

A played with this lightly. A few general comments:

- UI issues: the labels should be capitalized correctly, left aligned (set
xalign to 0), and use underline/mnemonics.

- Change the UI name of the device from 'PANIC' to 'Panic Notifier'. Might
need to do the same in the other virt-manager patch

- What's the point of iobase? When will a user ever want to change it? If it's
only rarely used, we might consider dropping the UI field for it.

Thanks,
Cole